Refactor thread safety of KeychainSwift class #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock to avoid the need in internal "deleteNoLock" method and remove it.
vykut
approved these changes
Dec 14, 2022
|
still needed / up to date? |
aehlke
added a commit
to lake-of-fire/keychain-swift
that referenced
this pull request
Jul 2, 2024
|
Yes |
|
I'm using it in production. Works well. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched
NSLocktoNSRecursiveLockto avoid the need for an internaldeleteNoLock()method and remove it.NSRecursiveLockis conform to the sameNSLockingprotocol asNSLockbut the fundamental difference is thatNSRecursiveLockallows locking resources recursively. The main rule here is.unlock()calls must be as much as.lock()calls.That is why we no more need the internal
deleteNoLockmethod, which was added, as I suppose, to avoiddeadlock.