Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large read_gsheet requests: use HTTP/1.0 #15

Merged
merged 1 commit into from
Oct 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/gsheets_requests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace duckdb
break;
}

std::string request = method_str + " " + path + " HTTP/1.1\r\n";
std::string request = method_str + " " + path + " HTTP/1.0\r\n";
request += "Host: " + host + "\r\n";
request += "Authorization: Bearer " + token + "\r\n";
request += "Connection: close\r\n";
Expand Down Expand Up @@ -80,7 +80,6 @@ namespace duckdb
BIO_free_all(bio);
SSL_CTX_free(ctx);

// Extract body from response
// Extract body from response
size_t body_start = response.find("\r\n\r\n");
if (body_start != std::string::npos)
Expand All @@ -101,6 +100,5 @@ namespace duckdb
}

return perform_https_request(host, path, token, method, body);
return perform_https_request(host, path, token, method, body);
}
}
Loading