UI(linter, formatter): setup biome (#1287)

evidentlyai · Sep 6, 2024 · 4d83af5 · 4d83af5
1 parent f0559e7
commit 4d83af5
Show file tree

Hide file tree

Showing 107 changed files with 1,554 additions and 4,430 deletions.
diff --git a/.github/share-actions/ui-node-pnpm-install/action.yml b/.github/share-actions/ui-node-pnpm-install/action.yml
@@ -1,4 +1,10 @@
 name: UI install
+inputs:
+  args:
+    type: string
+    description: ""
+    required: false
+    default: ""
 runs:
   using: "composite"
   steps:
@@ -15,5 +21,5 @@ runs:
 
     - name: 📥 Install node dependencies
       working-directory: ui
-      run: pnpm i --frozen-lockfile --ignore-scripts
+      run: pnpm i --frozen-lockfile --ignore-scripts ${{ inputs.args }}
       shell: bash
diff --git a/.github/workflows/ui.yml b/.github/workflows/ui.yml
@@ -57,6 +57,25 @@ jobs:
           echo "One or more evidently_python file(s) has changed."
           echo "List all the files that have changed: ${{ steps.changed-files.outputs.evidently_python_all_changed_and_modified_files }}"
 
+  code-check:
+    name: UI code check
+    runs-on: ubuntu-22.04
+    needs: changed_files
+    if: ${{ github.event.pull_request.draft == false && (needs.changed_files.outputs.ui_any_modified == 'true' || needs.changed_files.outputs.evidently_python_any_modified == 'true') }}
+
+    steps:
+      - name: ⬇️ Checkout repo
+        uses: actions/checkout@v4
+
+      - name: 📥 Install ui dependencies
+        uses: ./.github/share-actions/ui-node-pnpm-install
+        with:
+          args: "-w"
+
+      - name: 🔬 Check code quality
+        working-directory: ui
+        run: pnpm code-check
+
   ui-type-check:
     name: UI type-check
     runs-on: ubuntu-22.04

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -19,7 +19,8 @@ repos:
         args: [--exit-non-zero-on-fix, --fix]
       - id: ruff-format
 
-#  - repo: https://github.com/pre-commit/mirrors-prettier
-#    rev: "v3.0.3"
-#    hooks:
-#      - id: prettier
+  - repo: https://github.com/biomejs/pre-commit
+    rev: "v0.4.0"
+    hooks:
+      - id: biome-ci
+        additional_dependencies: ["@biomejs/biome@1.8.3"]
diff --git a/biome.jsonc b/biome.jsonc
@@ -0,0 +1,53 @@
+{
+  "files": {
+    // `endpoints.d.ts` is autogenerated
+    // `JsonParser.ts` copied from https://github.com/douglascrockford/JSON-js
+    "ignore": [
+      "ui/packages/evidently-ui-lib/src/**/JsonParser.ts",
+      "ui/packages/evidently-ui-lib/src/**/endpoints.d.ts",
+      "ui/packages/evidently-ui-lib/.tsc-dts/**"
+    ],
+    "include": ["ui/*/src/**", "ui/packages/*/src/**"]
+  },
+  "formatter": {
+    "enabled": true,
+    "formatWithErrors": false,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineEnding": "lf",
+    "lineWidth": 100,
+    "attributePosition": "auto"
+  },
+  "css": {
+    "linter": {
+      "enabled": true
+    },
+    "formatter": {
+      "enabled": true
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "arrowParentheses": "always",
+      "bracketSameLine": false,
+      "bracketSpacing": true,
+      "jsxQuoteStyle": "single",
+      "quoteStyle": "single",
+      "quoteProperties": "asNeeded",
+      "semicolons": "asNeeded",
+      "trailingCommas": "none"
+    }
+  },
+  "json": {
+    "formatter": {
+      "trailingCommas": "none"
+    }
+  },
+  "organizeImports": { "enabled": true },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  }
+}
diff --git a/src/evidently/nbextension/static/index.js b/src/evidently/nbextension/static/index.js
diff --git a/src/evidently/ui/assets/index.html b/src/evidently/ui/assets/index.html
@@ -11,8 +11,8 @@
       content="Evidently - ML Monitoring Demo. Hosted example to monitor the performance of a demand forecasting model on a toy dataset."
     />
     <title>Evidently - ML Monitoring Demo</title>
-    <script type="module" crossorigin src="/static/js/index-CKJqPvPP.js"></script>
-    <link rel="modulepreload" crossorigin href="/static/js/vendor-t0l2jWQ9.js">
+    <script type="module" crossorigin src="/static/js/index-NbS__BXi.js"></script>
+    <link rel="modulepreload" crossorigin href="/static/js/vendor-COAUpDWz.js">
     <link rel="stylesheet" crossorigin href="/static/css/index-_rehp6Bp.css">
   </head>
   <body>

diff --git a/.../assets/static/js/ContentCopy-B2vBgiMr.js → .../assets/static/js/ContentCopy-CTB-bCQn.js b/.../assets/static/js/ContentCopy-B2vBgiMr.js → .../assets/static/js/ContentCopy-CTB-bCQn.js
diff --git a/...ts/static/js/DashboardContent-C6JeNogA.js → ...ts/static/js/DashboardContent-DSoVlerH.js b/...ts/static/js/DashboardContent-C6JeNogA.js → ...ts/static/js/DashboardContent-DSoVlerH.js
diff --git a/src/evidently/ui/assets/static/js/DashboardViewParams-CHXlEHLP.js b/src/evidently/ui/assets/static/js/DashboardViewParams-CHXlEHLP.js
diff --git a/src/evidently/ui/assets/static/js/DashboardViewParams-DnRSqG_L.js b/src/evidently/ui/assets/static/js/DashboardViewParams-DnRSqG_L.js
@@ -0,0 +1 @@
+import{R as a,r as t}from"./vendor-COAUpDWz.js";const s=a.createContext(null),o=()=>t.useContext(s);export{s as D,o as u};
diff --git a/...ts/static/js/DashboardWidgets-CSvA9GhO.js → ...ts/static/js/DashboardWidgets-Bd_rYhaA.js b/...ts/static/js/DashboardWidgets-CSvA9GhO.js → ...ts/static/js/DashboardWidgets-Bd_rYhaA.js
diff --git a/...ntly/ui/assets/static/js/Edit-BJOpF2nO.js → ...ntly/ui/assets/static/js/Edit-ByX95MPl.js b/...ntly/ui/assets/static/js/Edit-BJOpF2nO.js → ...ntly/ui/assets/static/js/Edit-ByX95MPl.js
diff --git a/...ssets/static/js/createSvgIcon-LdZl81St.js → ...ssets/static/js/createSvgIcon-63W_9W2b.js b/...ssets/static/js/createSvgIcon-LdZl81St.js → ...ssets/static/js/createSvgIcon-63W_9W2b.js
diff --git a/src/evidently/ui/assets/static/js/index-BrZb1t9C.js b/src/evidently/ui/assets/static/js/index-BrZb1t9C.js
diff --git a/src/evidently/ui/assets/static/js/index-By5ZMnyu.js b/src/evidently/ui/assets/static/js/index-By5ZMnyu.js
diff --git a/...tly/ui/assets/static/js/index-DpaWFHTR.js → ...tly/ui/assets/static/js/index-CFjUf3L-.js b/...tly/ui/assets/static/js/index-DpaWFHTR.js → ...tly/ui/assets/static/js/index-CFjUf3L-.js
diff --git a/src/evidently/ui/assets/static/js/index-CIEFkcKx.js b/src/evidently/ui/assets/static/js/index-CIEFkcKx.js
diff --git a/src/evidently/ui/assets/static/js/index-CKJqPvPP.js b/src/evidently/ui/assets/static/js/index-CKJqPvPP.js
diff --git a/src/evidently/ui/assets/static/js/index-CcLP2flX.js b/src/evidently/ui/assets/static/js/index-CcLP2flX.js
diff --git a/src/evidently/ui/assets/static/js/index-DU-KQm24.js b/src/evidently/ui/assets/static/js/index-DU-KQm24.js
diff --git a/...tly/ui/assets/static/js/index-DsPNOD6z.js → ...tly/ui/assets/static/js/index-DY6tcX00.js b/...tly/ui/assets/static/js/index-DsPNOD6z.js → ...tly/ui/assets/static/js/index-DY6tcX00.js
diff --git a/src/evidently/ui/assets/static/js/index-DzU7Itgo.js b/src/evidently/ui/assets/static/js/index-DzU7Itgo.js
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		import{R as a,r as t}from"./vendor-COAUpDWz.js";const s=a.createContext(null),o=()=>t.useContext(s);export{s as D,o as u};