Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with hook template binary lookup / released binary on MacOS #232

Closed
PikachuEXE opened this issue Sep 27, 2021 · 3 comments
Closed

Comments

@PikachuEXE
Copy link
Contributor

In https://github.com/evilmartians/lefthook/blob/master/cmd/templates/hook.tmpl#L18-L20

It tried to look for ./node_modules/@arkweid/lefthook

But there are only multiple executable files inside folders for different platforms
image
image

I have no idea how to fix this

I am using SourceTree but it's able to detect base folder via
https://github.com/evilmartians/lefthook/blob/master/cmd/templates/hook.tmpl#L11

But I am still unable to use due to this issue

@PikachuEXE
Copy link
Contributor Author

Did some digging
The few lines looking for ./node_modules/@arkweid/lefthook was introduced in
b742f15

But .npm/bin/lefthook was removed in https://github.com/evilmartians/lefthook/pull/184/files#diff-7125027dcfcca72f8a28cb0a3710322e1e4d1e52e2e346262406129862262b18

I still got no clue on how to fix this issue yet...

@aminya
Copy link
Contributor

aminya commented Sep 27, 2021

The improvements were never fully released. So, don't expect it to work.

Also, your issue doesn't include an error.

@PikachuEXE
Copy link
Contributor Author

I think this should be a duplicate to #99 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants