-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite npm's scripts in JavaScript #184
Conversation
This removes the dependency on `sh` for a Node env. `sh` is not available on Windows
@DmitryTsepelev Could you take a look at this? It makes it possible to use lefthook on Windows. |
@aminya hello and thanks for the pull request. We're improving and maintaining Lefthook in the free time from commercial work, so we can't react to all contributions promptly. We will get to your PR some day, but in the meantime please be patient and don't mention random people in the team. Thank you for understanding. |
You're welcome. I am also contributing in my free time from my commercial work, and since the mentioned member approved two pull requests today, I added one kindly reminder. In the meantime, I am using my local fork, and I am not in rush at all. |
Windows support is especially hard to do right as we don't have anyone who is on Windows. That's why your contribution is especially valuable. @aminya, thank you very much! |
Released in 0.7.5. Thank you! |
You're welcome! |
The old optimization was rewritten but left this conditional statement which does nothing now evilmartians#184
sh
for a Node env, which is not available on Windows.sh
script anymore to slow things down. Nodejs itself spawns the executable directly.Fixes #183
Related to #16