Fix finding lefthook binary under node_modules #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
node_modules-binary
branch
3 times, most recently
from
ae71337 to
77329f7
Compare
aminya
changed the title
aminya
force-pushed
the
node_modules-binary
branch
3 times, most recently
from
ad212c7 to
e4d45dd
Compare
No matter what package manager is used, the binaries will be always under node_modules/.bin. The previous script only worked with "npm" which hoists the dependencies to node_modules. It also fixes finding binaries for the cases where $dir has spaces in it
aminya
force-pushed
the
node_modules-binary
branch
from
e4d45dd to
4987b04
Compare
aminya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #184, the lefthook sh file was removed, but the Node package managers create one automatically under
node_modules/.bin. This fixes finding binaries under node_modules no matter what package manager is used.It also fixes finding binaries for the cases where
$dirhas spaces in it (allowed on Windows)