Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add when "mingw" then "windows" case #297

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Conversation

ariccio
Copy link
Contributor

@ariccio ariccio commented Jul 14, 2022

Making this change locally allowed me to run lefthook. I do not know if there are any kind of ABI issues, I have no actual idea how lefthook works, but I suspect it's fine since it looks like there's no actual interface between go and ruby, only at the process level?

Fixes #296

Making this change locally allowed me to run lefthook. I do not *know* if there are any kind of ABI issues, I have no *actual* idea how lefthook works, but I suspect it's fine since it looks like there's no actual interface between go and ruby, only at the process level?

Fixes evilmartians#296
@mrexox
Copy link
Member

mrexox commented Jul 15, 2022

Hey! Thank you very much for the fix!

@ariccio
Copy link
Contributor Author

ariccio commented Jul 15, 2022

Heh, of all the weird environment issues I've faced the past few months, this was one of the only ones that was easy to figure out and fix!

Among them:

  1. Expo failing to connect to my laptop because for some reason only two devices on my local network have bad ARP tables, those two are my android dev device and my laptop, and the only thing missing from the table was precisely the two devices I wanted to talk to eachother... The only way I fixed that was nmaping the network, which apparently caused someone to update.
  2. Windows deciding to reserve ports in ways that other platforms seemingly don't, which leads to all kinds of confusion.
  3. libuv in node not handling errors in a generic way, so uncommon OS errors (like subtle disk corruption) cause hard-to-debug crashes. That one took a while.

@mrexox mrexox merged commit 2758015 into evilmartians:master Jul 17, 2022
@mrexox
Copy link
Member

mrexox commented Jul 19, 2022

Hey! I have released your fix with v1.0.5. Please, come back if you have any problem!

@ariccio ariccio deleted the patch-1 branch July 21, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lefthook crash - Unknown OS: mingw (RuntimeError)
2 participants