Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for git lfs #306

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

mrexox
Copy link
Member

@mrexox mrexox commented Aug 7, 2022

Closes #276

Summary ⚡

The approach is taken from Githooks:

  • Check if git-lfs is installed and the hook is supported by Git LFS
  • Run Git LFS hook before all the other hooks
  • Successful execution of LFS hooks is not mandatory for now. This might be changed in next major release.

Tested locally, noticed that git lfs ... hangs only if I set cmd.Stdin = os.Stdin. This is because pre-push hook reads from STDIN: https://www.mankier.com/1/git-lfs-pre-push. ⚠️ Lefthook won't support this for now.

Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
@mrexox mrexox marked this pull request as ready for review August 7, 2022 11:36
@mrexox mrexox mentioned this pull request Aug 7, 2022
Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
@mrexox mrexox merged commit f13756c into evilmartians:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support LFS internally
1 participant