Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove quoting for scripts #371

Merged
merged 4 commits into from
Nov 17, 2022
Merged

fix: Remove quoting for scripts #371

merged 4 commits into from
Nov 17, 2022

Conversation

mrexox
Copy link
Member

@mrexox mrexox commented Nov 17, 2022 •
edited
Loading

Closes #367, #369

🔧 Summary

Thanks to @stonesbg who found a regression. No need to quote the scripts path. This leads to a bug on Windows system.

@mrexox mrexox marked this pull request as ready for review November 17, 2022 10:54
@mrexox mrexox force-pushed the fix/remove-quoting-for-scripts branch from 60543d6 to 0545d09 Compare November 17, 2022 10:57
@mrexox mrexox changed the title Remove quoting for scripts fix: Remove quoting for scripts Nov 17, 2022
@mrexox mrexox merged commit 3fbb37d into evilmartians:master Nov 17, 2022
@mrexox mrexox deleted the fix/remove-quoting-for-scripts branch November 17, 2022 11:03
mrexox added a commit that referenced this pull request Nov 17, 2022
@mrexox
1.2.1: Various fixes
08120e6 
- Remove quoting for scripts (#371)
- remove lefthook.checksum on uninstall (#370)
- Print prepare-commit-msg hook if it exists in config (#368)
- Allow changing refs for remote (#363)

Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows scripts path resolution broken
1 participant
@mrexox