-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't show when commands are skipped because of no matched files #468
Conversation
… because of no matched files
I've been looking over the repo, and found this in the troubleshooting: https://github.com/evilmartians/lefthook/wiki/Troubleshooting#skip-no-files-for-inspecting
I'm not sure if this is accurate. This is a pretty old monolith, and I see this pretty often 😅 I'm able to "fix" it by having something that matches a pattern to be committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution! This totally makes sense (although skip skip
sounds funny). I have a small suggestion to refactor the code and put a skip settings check into a logSkip
function.
I'd also suggest to name the skip_output setting skips
, so it sounds a bit more natural (like, skip the skips) since we probably want to skip all kinds of skips logging that we have in lefthook 🙂
If you don't have time for these edits I can do it for you, but I'll wait for your response 🙌
Sure, that sounds good. I mostly did it to be consistent with the other variables. Although, unlike the others... "There are plenty places that log about skipping", so maybe that's more appropriate.
Can do! I considered that, but I wasn't able to see any of those locally. If you are good with it, I can make the change.
I can take care of it! Thanks for the offer though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Now everything is perfect!
Thanks! I appreciate the feedback, merging, and release 🌈 🚀 🌟 |
Closes #467
⚡ Summary
If you have lots of commands, and make small commits, you'll often see a lot of skipped commands:
I wanted a way to skip this. I'm migrating from a home grown hook runner, and it had pretty concise output that I'm trying to recreate. I was able to do that with most of the other options, but still had this output.
I apologize in advance, this is my first go contribution to anything 🤪
☑️ Checklist