fix: Do not print extraneous newlines when executionInfo output is hidden #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexox
reviewed
Jul 17, 2023
Comment on lines
+488
to
+492
| if execLog != "" { | ||
| log.Info(execLog) | ||
| } | ||
|
|
||
| if err == nil && r.SkipSettings.SkipExecutionOutput() { |
There was a problem hiding this comment.
The check for execution skipping should go first.
There was a problem hiding this comment.
Done 👍
So I guess this means that the previous log.Info(execLog) was not intended to be there - Because it seems that now the behavior just changed so that execLog is never printed when the condition err == nil && r.SkipSettings.SkipExecutionOutput() is met.
There was a problem hiding this comment.
Oh god, I'm sorry. execLog shouldn't be printed if it is empty. That's right. And if we have SkipExecutionOutput() then we don't print command output. So, your previous solution was correct. Let me fix that.
There was a problem hiding this comment.
Haha yeah I thought something was fishy - glad it's sorted out now 😅
mrexox
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #494
⚡ Summary
Prevents printing blank lines when
exececutionInfois not printed.Previously, two newlines would be printed for each command (Effectively
fmt.Println("\n")). This fixes that.☑️ Checklist