Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LEFTHOOK_VERBOSE properly overrides --verbose flag #521

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: LEFTHOOK_VERBOSE properly overrides --verbose flag #521

merged 2 commits into from
Jul 17, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Jul 14, 2023 •
edited
Loading

Closes # (issue)

⚡ Summary

Previously, setting LEFTHOOK_VERBOSE would have no effect since cobra defaulted options.Verbose to false. And because options.Verbose wasn't overridden from the start, it would remain false.

☑️ Checklist

  • Check locally
  • Add tests

@mrexox mrexox merged commit 193190b into evilmartians:master Jul 17, 2023
@hyperupcall hyperupcall mentioned this pull request Jul 19, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperupcall @mrexox