Support relative roots for monorepos (#72) #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I'll check it soon. |
|
@Arkweid let me know. My team is eager to use this on our project 😉 |
|
Of course. I just usually have a time on weekends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did my best as a non-golang expert to implement #72 with as little code as possible.
Feedback
It appears there is a step missing from the
CONTRIBUTING.mdfile about how to getlefthookinto the top of$PATH. I had to usegem uninstall lefthookand thengo installto get the specs to run. However those also failed to pass because I am assuming there is more set up to do that I must have missed.