-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump pavao to fix samba linkage for homebrew builds #63
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
I have already tested this change for legba build, might be worth a new release per the merge. |
oh man i had to do this fd92fbf and i hated it so much, this is great! definitely worth a new release, thank you <3 |
@chenrui333 are you sure this fixes it? I'm still getting: Full compilation log that confirms the use of pavao 0.2.8:
|
yeah, I am pretty sure, I have tested against v0.10.0, let me try the patch again (I was using my commit earlier, now I am using a released version 0.2.8) |
you are right, it is not fixed, digging a bit. |
yeah, found the root cause, it is actually the install_name issue with the brew samba installation
the install_name for dylib would be handled in |
with veeso/pavao#23 being merged and released, we can now use pavao 0.2.8 for macos builds
fixes #40
cc @evilsocket