Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit option does not work on newly cloned rule in opensnitch UI #1027

Closed
brbar opened this issue Aug 25, 2023 · 2 comments
Closed

Edit option does not work on newly cloned rule in opensnitch UI #1027

brbar opened this issue Aug 25, 2023 · 2 comments

Comments

@brbar
Copy link

brbar commented Aug 25, 2023

If you clone the rule and try to edit it - nothing will happen.
I'm using the recent version of opensnitch 1.6.3.

Steps to reproduce:

  1. Clone an existing rule
  2. Click edit on newly cloned rule. Edit rule window will not open.
@lainedfles
Copy link
Contributor

@brbar You may need to provide more information about your environment, i.e. OS version, display environment, etc. Additionally, UI & daemon debug logging may shed some light on your problem; I'm unable to re-produce it per your description via master build of 1.6.3. Does this occur with a specific rule or any?

@gustavo-iniguez-goya
Copy link
Collaborator

hey @brbar ,

I think this issue has been partially fixed on v1.6.4. At least it opens the rules editor dialog.

The reason that could have caused this error might have been a typo, fixed here: 72756c8

But I realize, that the fields of the rules are not displayed in the dialog, if the type is "list". I'll investigate it.

gustavo-iniguez-goya added a commit that referenced this issue Jan 8, 2024
@gustavo-iniguez-goya
ui,stats: fixed adding rules to the db from context menu
ec3f515 
When cloning a rule, or applying a rule to a node, if the rule was of
type List (had multiple operators), the operators were not saved to the
DB.

Closes: #1027
(cherry picked from commit 4499a5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gustavo-iniguez-goya @brbar @lainedfles