Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probed function sys_execve to do_execve #188

Merged
merged 5 commits into from
Sep 6, 2018

Conversation

Northern-Lights
Copy link
Contributor

This is to address #184: #184

sys_execve does not appear to be an available filter function:

# grep execve /sys/kernel/debug/tracing/available_filter_functions 
audit_log_execve_info
do_execveat_common.isra.37
__ia32_compat_sys_execve
__ia32_compat_sys_execveat
__ia32_sys_execve
__ia32_sys_execveat
__x64_sys_execve
__x64_sys_execveat
do_execve
do_execveat

In order to fix this, I tried __x64_sys_execve and do_execve. Both appear to allow the daemon to proceed with initialization and to properly operate the packet filter. The UI connects to the daemon and pops up windows upon alerts with no issue.

@Northern-Lights
Copy link
Contributor Author

If changing the syscall will break compatibility, I could make a slice of possible syscalls, e.g. []string{"sys_execve", "do_execve"}. Then, if an error is returned on the first one, we can move on and try the next.

@evilsocket
Copy link
Owner

need some time to test this, did you go for the slice approach?

@evilsocket evilsocket merged commit 980876e into evilsocket:master Sep 6, 2018
@Northern-Lights
Copy link
Contributor Author

Sorry, I saw your comment a little late. It is not currently trying both in a slice, although I see you've already merged the PR. I'll be happy to add it in if anything pops up in the issues section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants