Fixes attachment of dns uprobes when libc is stripped of symbol names #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (.dynsym instead of .symtab)
JeremyMahieu
changed the title
|
Thank you @JeremyMahieu ! Tested on Debian (symbols stripped) and Fedora 3x (not stripped) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arch linux, and likely other distros, libc.so.6 is shipped stripped by default. this means
.symtabdoes not exist andelffile.Symbols()returns with "no symbol section" error resulting in dns uprobes being unable to be attached. This pr changes the call to.DynamicSymbols()to alleviate this problem. This ensures a broader range of distro compatibility.