Use temporary files instead of piping in ebpf Makefile #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when compiling the eBPF module, in the Makefile, the output of
clang
is directly piped tollc
. This is bad, because in this case, shouldclang
fail,llc
still runs, but produces faulty.o
files.make
never picks up on it and doesn't abort compilation - a success is reported across the board (apart from theclang
log).This patch removes the file and explicitly writes (and later deletes)
clang
's output to a.partial
file. This is later used as the input ofllc
.