Convert tryCatch to nAry (#318) #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilsoft
approved these changes
Oct 7, 2018
There was a problem hiding this comment.
This 👀 GTG!
As we are changing the interface for this, thinking it should be marked as a Breaking Change.
We are going to do a 0.10.2 release with some features and a bug fix, then this should go out with 0.11.0 which will be the release after this next one.
What do you think about updating the documentation to make note of this new super power?
|
Sure, I'll get that in today.
…On Sun, Oct 7, 2018, 8:35 AM Ian Hofmann-Hicks ***@***.***> wrote:
***@***.**** approved this pull request.
This 👀 GTG!
As we are changing the interface for this, thinking it should be marked as
a Breaking Change.
We are going to do a 0.10.2 release with some features and a bug fix,
then this should go out with 0.11.0 which will be the release after this
next one.
What do you think about updating the documentation to make note of this
new super power?
[image: image]
<https://user-images.githubusercontent.com/3665793/46579132-70501380-c9c0-11e8-91a2-8bc085cd3c4e.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#320 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH4KbxK29XcKPP_FmmEmokDkHK8hcoLTks5uiaCYgaJpZM4XJ3pf>
.
|
evilsoft
reviewed
Oct 27, 2018
| const noncurried = tryCatch(x, 1,2,3).either(identity, identity) | ||
| const curried = tryCatch(x, 1)(2)(3).either(identity, identity) | ||
|
|
||
| t.equals(equals(noncurried, { a: 1, b: 2, c: 3 }), true, 'preserves the arity of the passed function') |
There was a problem hiding this comment.
instead of equals with an equals function checking for true, tape provides same.
But this is okay, I have done this a lot myself and it still is a vaild test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.