Prevent fromPromise from swallowing errors (#334) #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilsoft
approved these changes
Oct 27, 2018
There was a problem hiding this comment.
We need to put coverage around Computational Crashes, that is how this slipped through.
For now tho, peeps are broken on 0.10.2 and we need to change our forking scheme to be able to allow for Crash detection.
I am okay with this going out and us adding the coverage before any other work is done on Async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #334
We still need to figure out how to test for this particular behaviour, since we need to test against an
UnhandledPromiseRejection. Related: tape-testing/tape#208