Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Commit

Permalink
internal/ethapi: add note about eth_chainId compatibility with EIP-69…
Browse files Browse the repository at this point in the history
…5 (geth #25168)
  • Loading branch information
VictorTrustyDev committed Nov 10, 2022
1 parent d9e17a7 commit 57bfdaa
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions rpc/namespaces/ethereum/eth/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,11 @@ func (e *PublicAPI) MaxPriorityFeePerGas() (*hexutil.Big, error) {
}

// ChainId is the EIP-155 replay-protection chain id for the current ethereum chain config.
//
// Note, this method does not conform to EIP-695 because the configured chain ID is always
// returned, regardless of the current head block. We used to return an error when the chain
// wasn't synced up to a block where EIP-155 is enabled, but this behavior caused issues
// in CL clients.
func (e *PublicAPI) ChainId() *hexutil.Big { //nolint
e.logger.Debug("eth_chainId")
return e.backend.ChainID()
Expand Down

0 comments on commit 57bfdaa

Please sign in to comment.