fix(rpc): optimize eth_getBalance endpoint (#1169)

* optimize get balance endpoint * add comment * add changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
evmos · Jul 12, 2022 · f2bd4e7 · f2bd4e7
1 parent e6af0b4
commit f2bd4e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,12 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 # Changelog
 
+## [v0.11.1] - 2022-07-13
+
+### Improvements
+
+* (rpc) [\#1169](https://github.com/evmos/ethermint/pull/1169) Remove unnecessary queries from `getBlockNumber` function
+
 ## [v0.11.0] - 2022-03-06
 
 ### State Machine Breaking

diff --git a/rpc/ethereum/namespaces/eth/api.go b/rpc/ethereum/namespaces/eth/api.go
@@ -1102,11 +1102,11 @@ func (e *PublicAPI) getBlockNumber(blockNrOrHash rpctypes.BlockNumberOrHash) (rp
  case blockNrOrHash.BlockHash == nil && blockNrOrHash.BlockNumber == nil:
  return rpctypes.EthEarliestBlockNumber, fmt.Errorf("types BlockHash and BlockNumber cannot be both nil")
  case blockNrOrHash.BlockHash != nil:
- blockHeader, err := e.backend.HeaderByHash(*blockNrOrHash.BlockHash)
+ blockNumber, err := e.backend.GetBlockNumberByHash(*blockNrOrHash.BlockHash)
  if err != nil {
  return rpctypes.EthEarliestBlockNumber, err
  }
- return rpctypes.NewBlockNumber(blockHeader.Number), nil
+ return rpctypes.NewBlockNumber(blockNumber), nil
  case blockNrOrHash.BlockNumber != nil:
  return *blockNrOrHash.BlockNumber, nil
  default: