Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Need an api to recover execution result from the false-failed tx #1052

Closed
yihuang opened this issue Apr 15, 2022 · 3 comments · Fixed by #1056
Closed

Need an api to recover execution result from the false-failed tx #1052

yihuang opened this issue Apr 15, 2022 · 3 comments · Fixed by #1056

Comments

@yihuang
Copy link
Contributor

yihuang commented Apr 15, 2022

Proposal: Need an api to recover execution result from the false-failed tx

Current behavior:

On cronos mainnet, due to an old bug(cosmos/cosmos-sdk#10770), there are transactions that success on chain but return a failed result, although the bug itself is fixed, we need to figure out a way to patch the old data.
One solution is to support sth like: debug_runTransactionByBlockAndIndex, so we can rerun these transactions and get back the correct tx result.

Desired behavior: The old tx data should be recovered too.

Use case: Fix the old tx result.

@fedekunze
Copy link
Contributor

fedekunze commented Apr 15, 2022

I think we should modularize the RPC so that projects can add their own namespaces and endpoints to existing namespaces. This would fix your issue without adding custom endpoints

@yihuang
Copy link
Contributor Author

yihuang commented Apr 15, 2022

I think we should modularize the RPC so that projects can add their own namespaces and endpoints to existing namespaces. This would fix your issue without adding custom endpoints

maybe add a custom grpc query in cronos is enough, no need to do this in ethermint, we'll try that.

@zhaojun-sh
Copy link

On cronos mainnet, due to an old bug(cosmos/cosmos-sdk#10770), there are transactions that success on chain but return a failed result, although the bug itself is fixed, we need to figure out a way to patch the old data.

This type transaction should be correctly identified by Metamask, Explorer, Bridge, etc. It requires compliance with the eth_getTransactionReceipt API.

curl --location --request POST 'https://evm-cronos.crypto.org/' --header 'Content-Type: application/json' --data-raw '{"jsonrpc":"2.0", "method":"eth_getTransactionReceipt", "params":["0xdc77a3531c737bdac89da5184189455a4f542bb1971670909be2e0e6eff6783c"],"id":1}'

yihuang added a commit to yihuang/ethermint that referenced this issue Apr 19, 2022
fedekunze added a commit that referenced this issue Apr 19, 2022
* make jsonrpc api namespaces extensible

Closes: #1052, #1037

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang added a commit to yihuang/ethermint that referenced this issue Apr 20, 2022
* make jsonrpc api namespaces extensible

Closes: evmos#1052, evmos#1037

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang added a commit to yihuang/ethermint that referenced this issue Apr 27, 2022
* make jsonrpc api namespaces extensible

Closes: evmos#1052, evmos#1037

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants