Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

eth_coinbase address does not correspond to an account #112

Closed
yihuang opened this issue Jun 11, 2021 · 1 comment · Fixed by #153
Closed

eth_coinbase address does not correspond to an account #112

yihuang opened this issue Jun 11, 2021 · 1 comment · Fixed by #153
Assignees
Labels
C:JSON-RPC JSON-RPC client help wanted Extra attention is needed

Comments

@yihuang
Copy link
Contributor

yihuang commented Jun 11, 2021

System info: [Include Ethermint commit, operating system name, and other relevant details]

Steps to reproduce:

Currently, what coinbase api returns is the consensus address, there's no correspond bank account for it, and I believe it's not the "address that staking rewards will be send to" as mentioned in comment. We should do a conversion(GetValidatorByConsAddr) and return the validator address to avoid confusion.
But we don't have direct access to the keeper in eth rpc layer, we need to add a convert api in cosmos-sdk first.

@fedekunze
Copy link
Contributor

correct, technically speaking, the coinbase address is the address that mining rewards will be send to. We can return the validator address in hex format by adding support to this staking query on the evm Query Service

@fedekunze fedekunze changed the title eth_coinbase result is not correspond to an account eth_coinbase address does not correspond to an account Jun 11, 2021
@fedekunze fedekunze added C:JSON-RPC JSON-RPC client help wanted Extra attention is needed labels Jun 12, 2021
@thomas-nguy thomas-nguy self-assigned this Jun 17, 2021
@khoslaventures khoslaventures added this to the Milestone 1: Developer Usability and Testing milestone Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:JSON-RPC JSON-RPC client help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants