This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 566
fix coinbase rpc endpoint to return ethereum address of the validator #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
force-pushed
the
thomas/coinbase
branch
2 times, most recently
from
June 21, 2021 11:55
a44fec9
to
61e491a
Compare
fedekunze
suggested changes
Jun 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good, although can be simplified (see comments). Also if you could add a test for the query on grpc_test.go
🙏
thomas-nguy
force-pushed
the
thomas/coinbase
branch
from
June 22, 2021 03:24
5d3792f
to
c7a9732
Compare
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 48.84% 47.98% -0.86%
==========================================
Files 43 43
Lines 2848 2932 +84
==========================================
+ Hits 1391 1407 +16
- Misses 1389 1454 +65
- Partials 68 71 +3
|
fedekunze
reviewed
Jun 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Pending test and lint fixes
fedekunze
reviewed
Jun 22, 2021
thomas-nguy
force-pushed
the
thomas/coinbase
branch
from
June 22, 2021 09:31
7870f8d
to
9736bfd
Compare
fedekunze
reviewed
Jun 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #112
Description
Coinbase previously was returning the operator address of the validator in hex format.
After this PR, eth_coinbase will return the ethereum format address of the account of the validator
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)