-
Notifications
You must be signed in to change notification settings - Fork 566
Improve Logs performance #563
Comments
It's strange that emitting cosmos events could become a bottleneck, I'll have a look. |
There are two changes we did to tx logs handling:
The first step is the same as before, the second step can be considered as the counterpart of the storage flushing in the previous approach, but the storage flushing is not covered in the benchmark, while the event emitting is, so that might explain the difference. |
@fedekunze do you think any log issues in the latest codebase we need to improve? |
This issue is stale because it has been open 45 days with no activity. Remove |
This issue should be fixed by #729 too. |
This issue is stale because it has been open 45 days with no activity. Remove |
Emitting tx logs decreased its performance due to #556 (see benchmarks).
Our tradeoff was decreasing the amount of state used in favor of this new approach, but we should come up with a new implementation that doesn't affect performance negatively.
cc @yihuang
The text was updated successfully, but these errors were encountered: