Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Improve Logs performance #563

Closed
fedekunze opened this issue Sep 15, 2021 · 7 comments
Closed

Improve Logs performance #563

fedekunze opened this issue Sep 15, 2021 · 7 comments
Assignees
Labels
Status: Stale Type: Performance Degraded or increased performance issues

Comments

@fedekunze
Copy link
Contributor

Emitting tx logs decreased its performance due to #556 (see benchmarks).

Our tradeoff was decreasing the amount of state used in favor of this new approach, but we should come up with a new implementation that doesn't affect performance negatively.

cc @yihuang

@fedekunze fedekunze added the Type: Performance Degraded or increased performance issues label Sep 15, 2021
@yihuang
Copy link
Contributor

yihuang commented Sep 16, 2021

It's strange that emitting cosmos events could become a bottleneck, I'll have a look.

@yihuang
Copy link
Contributor

yihuang commented Sep 16, 2021

There are two changes we did to tx logs handling:

  • Change tx log storage from normal store to transient store
  • Emit all the logs as events at the end of tx processing

The first step is the same as before, the second step can be considered as the counterpart of the storage flushing in the previous approach, but the storage flushing is not covered in the benchmark, while the event emitting is, so that might explain the difference.

@tomtau
Copy link
Contributor

tomtau commented Oct 28, 2021

@JayT106 can this issue be closed after #587 or are there more performance improvements to be done?

@JayT106
Copy link
Contributor

JayT106 commented Oct 28, 2021

@fedekunze do you think any log issues in the latest codebase we need to improve?

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@yihuang
Copy link
Contributor

yihuang commented Dec 15, 2021

This issue should be fixed by #729 too.

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Stale Type: Performance Degraded or increased performance issues
Projects
None yet
Development

No branches or pull requests

4 participants