This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Apply the bloom filter when query the ethlogs with range of blocks #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://dashboard.github.orijtech.com?back=0&pr=570&remote=false&repo=tharsis%2Fethermint to see benchmark details. |
github-actions
bot
added
C:JSON-RPC
|
also ref: #563 |
|
Will extend the test cases to enlarge the coverage. |
JayT106
force-pushed
the
getLog-withBloomFilter
branch
from
0ac1349 to
e93aab7
Compare
JayT106
force-pushed
the
getLog-withBloomFilter
branch
from
e93aab7 to
abb4318
Compare
JayT106
changed the title
fedekunze
reviewed
Sep 21, 2021
Comment on lines
+768
to
+779
| // checkMatches revised the function from | ||
| // https://github.com/ethereum/go-ethereum/blob/401354976bb44f0ad4455ca1e0b5c0dc31d9a5f5/core/types/bloom9.go#L88 | ||
| func checkMatches(bloom ethtypes.Bloom, filter []filters.BloomIV) bool { | ||
| for _, bloomIV := range filter { | ||
| if bloomIV.V[0] == bloomIV.V[0]&bloom[bloomIV.I[0]] && | ||
| bloomIV.V[1] == bloomIV.V[1]&bloom[bloomIV.I[1]] && | ||
| bloomIV.V[2] == bloomIV.V[2]&bloom[bloomIV.I[2]] { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
can we use the BloomLookup func instead?
There was a problem hiding this comment.
The reason I didn't use BloomLookup is trying to avoid the calculation in https://github.com/ethereum/go-ethereum/blob/401354976bb44f0ad4455ca1e0b5c0dc31d9a5f5/core/types/bloom9.go#L139
If we use it, the bloom for the addresses and the topics in the filter will be calculated against every block.
Also this PR I can put the one-time bloom calculation when the RPC layer creates the filter.
|
close this PR and open it in #587 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #303
Description
This PR revised the implementation in the filter, uses
Bloom index&value setsinstead ofbloombits.Matcherwhich doesn't have the bloom indexer DB implementation in the Ethermint project.Therefore,
eth_getLogscan skip extra data check overhead by only checking the bloom of the block header, and then returns the transaction logs that fit the query criteria.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)