-
Notifications
You must be signed in to change notification settings - Fork 561
Inconsistent transaction hashing with Tendermint #67
Comments
If don't modify tendermint itself, we can store the hash relationship on chain? |
that's an option, but we would have to prune the entries at some point. The map would have to be |
another thing about tx hash is, if we maintain hash relationship by ourself, we might be able to support multiple eth tx in one tm tx, just maintain the map of |
Let's implement the map as a short-term solution. The update to Tendermint probably won't be included in a release soon... |
We already emit the eth tx hash in events, so as long as enabled indexing in tendermint, we can query |
Closes #67 Update ethereum/rpc/namespaces/eth/api.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Update ethereum/rpc/namespaces/eth/api.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> change GetTxByEthHash to method add entry to changelog
* return eth tx hash to client Closes #67 Update ethereum/rpc/namespaces/eth/api.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Update ethereum/rpc/namespaces/eth/api.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> change GetTxByEthHash to method add entry to changelog * use eth tx hash internally
The hash that a user or library would expect from sending an ethereum tx over JSON-RPC doesn't match the one provided by the
ResponseDeliverTx
on Tendermint.ref: tendermint/tendermint#6539
The text was updated successfully, but these errors were encountered: