This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 569
Problem: eip-1559 tx fee deduction is problematic #814
Comments
yihuang
changed the title
Problem: base fee is not deducted in ante handler
Problem: eip-1559 tx fee deduction is problematic
Dec 8, 2021
Solution:
Extra issue: we should return |
11 tasks
yihuang
added a commit
to yihuang/ethermint
that referenced
this issue
Dec 9, 2021
Closes: evmos#814 Solution: - use effectiveGasPrice when check minimal-gas-prices, and deduct fee in ante handler - implement an EthMempoolFeeDecorator
fedekunze
added a commit
that referenced
this issue
Dec 15, 2021
* Use effectiveGasPrice in ante handler for dynamic fee tx Closes: #814 Solution: - use effectiveGasPrice when check minimal-gas-prices, and deduct fee in ante handler - implement an EthMempoolFeeDecorator * add effectiveGasPrice to tx receipt * changelog * fix unit test * fix comments * add comments * Apply suggestions from code review Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com> * review suggestions Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
System info: ethermint main
Steps to reproduce:
/block_results
:The root cause is in ante handler, it deduct fee using tip gas price, while when refund gas, it use the full gas-price.
Expected behavior: eip-1559 tx should work.
Actual behavior: refund gas error
Additional info:
Deduct fee in ante handler using the
GasFeeCap
should solve this error, need to further check if it's complaint to go-ethereum behavior.The text was updated successfully, but these errors were encountered: