Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: base fee is not updated in begin block #820

Closed
yihuang opened this issue Dec 10, 2021 · 0 comments · Fixed by #822
Closed

Problem: base fee is not updated in begin block #820

yihuang opened this issue Dec 10, 2021 · 0 comments · Fixed by #822

Comments

@yihuang
Copy link
Contributor

yihuang commented Dec 10, 2021

System info: ethermint main

Steps to reproduce:

Currently base fee is updated in EndBlock, which is compliant with eip-1559 spec and go-ethereum implementation.

  1. do a dynamic fee tx, get the receipt
  2. fetch the base fee getBlock(receipt.blockNumber).baseFee
  3. try to reproduce the fee, it don't match.

Expected behavior: should be compliant with go-ethereum

Actual behavior: not

Additional info: [Include gist of relevant config, logs, etc.]
yihuang added a commit to yihuang/ethermint that referenced this issue Dec 10, 2021
@yihuang
Update base fee in begin blocker
5009edb 
Closes: evmos#820
@yihuang yihuang mentioned this issue Dec 10, 2021
Merged
11 tasks
fedekunze added a commit that referenced this issue Dec 15, 2021
@yihuang @fedekunze
feemarket: update base fee in BeginBlock (#822)
50e4637 
* Update base fee in begin blocker

Closes: #820

* changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update base fee in begin blocker yihuang/ethermint
1 participant
@yihuang