Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

eth_getBlockByNumber fix on batch transactions #1050

Merged
merged 7 commits into from
Apr 18, 2022
Merged

eth_getBlockByNumber fix on batch transactions #1050

merged 7 commits into from
Apr 18, 2022

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

Clean PR to solve txIndex issue on eth_getBlockByNumber transactionIndex on batch transactions.

Added temporary tests for batch transactions while OpenRPC implementation is done.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@crypto-facs crypto-facs changed the title Rpc index fix eth_getBlockByNumber fix on batch transactions Apr 14, 2022
fedekunze
fedekunze approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK minor comments

tests/e2e/integration_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
tests/e2e/integration_test.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) April 16, 2022 17:30
@fedekunze fedekunze disabled auto-merge April 18, 2022 14:58
@fedekunze fedekunze merged commit 7e35906 into evmos:main Apr 18, 2022
yihuang pushed a commit to yihuang/ethermint that referenced this pull request Apr 26, 2022
@crypto-facs @yihuang
eth_getBlockByNumber fix on batch transactions (evmos#1050)
6c3f9f1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crypto-facs @fedekunze