Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: gas price returned in getTransaction api #1082

Merged
merged 2 commits into from
May 19, 2022
Merged

fix: gas price returned in getTransaction api #1082

merged 2 commits into from
May 19, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented May 13, 2022 •
edited
Loading

Description

Solution:

  • pass the correct baseFee parameter to function NewTransactionFromMsg

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang changed the title fix gas price returned in getTransaction api fix: gas price returned in getTransaction api May 13, 2022
@yihuang
fix gas price returned in getTransaction api
beeaf75 
Solution:
- pass the correct baseFee parameter
@yihuang
Copy link
Contributor Author

yihuang commented May 16, 2022

the rpc test failure seems not relevant to this PR?

fedekunze
fedekunze approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. We need to start working on #1061 to be able to catch these errors sooner

@fedekunze fedekunze enabled auto-merge (squash) May 19, 2022 06:43
@fedekunze fedekunze merged commit d359cbd into evmos:main May 19, 2022
@yihuang yihuang deleted the fix-gas-price branch May 19, 2022 07:04
yihuang added a commit to yihuang/ethermint that referenced this pull request May 24, 2022
@yihuang @fedekunze
fix: gas price value in eth_getTransaction JSON-RPC response (evmos…
1af2a75 
…#1082)

Solution:
- pass the correct baseFee parameter

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @fedekunze