Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Move CanTransfer decorator before GasConsume #1111

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

Small change to move the CanTransfer (checks if the sender is allowed to transfer funds) decorator before the GasConsume decorator.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@crypto-facs crypto-facs changed the title move CanTransfer decorator before GasConsume Move CanTransfer decorator before GasConsume Jun 4, 2022
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #1111 (f915626) into main (da99f11) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1111   +/-   ##
=======================================
  Coverage   61.36%   61.36%           
=======================================
  Files          88       88           
  Lines        7213     7213           
=======================================
  Hits         4426     4426           
  Misses       2563     2563           
  Partials      224      224           
Impacted Files Coverage Δ
app/ante/handler_options.go 79.16% <100.00%> (ø)

@fedekunze fedekunze merged commit 8155e1f into evmos:main Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants