This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
sdk v0.45.8, tendermint v0.34.21, iavl v0.19.1 & store options #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
4 tasks
faddat
commented
Aug 25, 2022
| @@ -292,7 +292,10 @@ func (c TLSConfig) Validate() error { | |||
|
|
|||
| // GetConfig returns a fully parsed Config object. | |||
| func GetConfig(v *viper.Viper) Config { | |||
| cfg := config.GetConfig(v) | |||
| cfg, err := config.GetConfig(v) | |||
There was a problem hiding this comment.
Please review the error check here. There could be a better way to do this like either making the whole function return an error, or just using a blank in place of err.
There was a problem hiding this comment.
Changed this to return the error instead
faddat
commented
Aug 25, 2022
12 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v0.19.x #1301 +/- ##
===================================================
- Coverage 51.20% 51.16% -0.05%
===================================================
Files 103 103
Lines 9352 9358 +6
===================================================
- Hits 4789 4788 -1
- Misses 4304 4310 +6
- Partials 259 260 +1
|
facs95
approved these changes
Aug 29, 2022
| @@ -292,7 +292,10 @@ func (c TLSConfig) Validate() error { | |||
|
|
|||
| // GetConfig returns a fully parsed Config object. | |||
| func GetConfig(v *viper.Viper) Config { | |||
| cfg := config.GetConfig(v) | |||
| cfg, err := config.GetConfig(v) | |||
There was a problem hiding this comment.
Changed this to return the error instead
|
|
|
@danburck I think it is because I am making pr's from an external repo |
devon-chain
pushed a commit
to PundiAI/ethermint
that referenced
this pull request
Nov 17, 2022
…#1301) * sdk v0.45.8, tendermint v0.34.21, iavl v0.19.1 & store options * update gomod2nix * return error instead of panic * add Changelog Co-authored-by: Freddy Caceres <facs95@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Evmos v8.0.x is slated to use sdk v0.45.7 and ibc-go v3.2.0 and both of these enable the iavl fast cache features.
Currently ethermint did not have these and this was causing:
evmos/evmos#868
This patch bumps ethermint's release/v0.19.x branch to:
Mixing fast-cache enabled libraries and non-fast-cache enabled libraries seems not to go well.
Suggested way forward
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)