Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Antehandler optimization - revision #1393

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

Vvaradinov
Copy link
Contributor

Description

A small refactor to the below reference PR. To avoid calling params for every message retrieve them before the loop. Additionally in order to stay consistent with the structure to the rest of the repo use detailed variable declaration

Closes: #1388 (review)


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@Vvaradinov Vvaradinov changed the title Added changes recommended for better performance Antehandler optimization - revision Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1393 (6291d17) into main (3ab761b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   56.04%   56.05%           
=======================================
  Files         108      108           
  Lines       10074    10074           
=======================================
+ Hits         5646     5647    +1     
+ Misses       4144     4143    -1     
  Partials      284      284           
Impacted Files Coverage Δ
app/ante/eth.go 80.42% <100.00%> (+0.26%) ⬆️
x/evm/keeper/params.go 100.00% <100.00%> (ø)
x/feemarket/keeper/params.go 89.28% <100.00%> (ø)

@Vvaradinov Vvaradinov marked this pull request as ready for review October 20, 2022 08:03
@Vvaradinov Vvaradinov requested a review from a team as a code owner October 20, 2022 08:03
@Vvaradinov Vvaradinov requested review from GAtom22 and removed request for a team October 20, 2022 08:03
@fedekunze fedekunze merged commit 157f188 into main Oct 20, 2022
@fedekunze fedekunze deleted the Vvaradinov/antehandler-gas-optimization-revision branch October 20, 2022 11:40
yihuang added a commit to crypto-org-chain/ethermint that referenced this pull request Nov 3, 2022
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants