fix: chain-id in grpc query is not initialized without abci event

[yihuang]

Closes: #1404

Description

• pass the chain-id from caller.

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #1405 (6d17c66) into main (6455785) will decrease coverage by 0.00%.
The diff coverage is 69.23%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   67.94%   67.94%   -0.01%     
==========================================
  Files         109      109              
  Lines       10268    10295      +27     
==========================================
+ Hits         6977     6995      +18     
- Misses       2913     2919       +6     
- Partials      378      381       +3     

Impacted Files	Coverage Δ
x/evm/keeper/grpc_query.go	87.22% <58.62%> (-1.46%)	⬇️
rpc/backend/call_tx.go	61.05% <100.00%> (+0.52%)	⬆️
rpc/backend/tracing.go	63.63% <100.00%> (+0.61%)	⬆️
x/evm/keeper/state_transition.go	82.75% <100.00%> (ø)

[fedekunze]

Left some comments. Please also add test cases that fix the error that was reported in the issue

[yihuang]

Left some comments. Please also add test cases that fix the error that was reported in the issue

It seems not easy to setup the env in unit test, I can try to add integration test later.
The test env needed:

• A non empty chain, otherwise TraceTx fail for different reason.
• A newly constructed app.
• no abci event executed.
• test TraceTx api fail if chainId in request is empty as well, and success otherwise.

To test the difference with EthCall is ever more difficult, because the effect is different chain id observed by smart contract through CHAINID opcode.

[yihuang]

• I just refactored the code to not caching chain-id on evm keeper at all, just parse it on the fly.
• also add an alternative ParseChainID implementation which is around 8x faster than the regex one, but it's more tolerate than the regex one though:

$ go test -bench=. ./types/...  -run ^$
goos: darwin
goarch: amd64
pkg: github.com/evmos/ethermint/types
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkParseChainID-12          	 9688164	       112.5 ns/op	      40 B/op	       2 allocs/op
BenchmarkParseChainIDLegacy-12    	 1414352	       845.1 ns/op	     200 B/op	       5 allocs/op
PASS
ok  	github.com/evmos/ethermint/types	3.753s

[fedekunze]

Please revert changes out of the scope of this PR

[yihuang]

Please revert changes out of the scope of this PR

yeah, I reverted those, only kept the chain-id parameter of EVMConfig function, so grpc query will avoid using the cached chain-id, but consensus state machine still use it.

[facs95]

LGTM! 🚀