This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
fix: non-deterministic evm execution result #1436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Nov 8, 2022
When there's extra-eips, concurrent query could cause non-deterministic evm execution result. It could affect even if exists in historical states. Ref: ethereum/go-ethereum#26137
yihuang
force-pushed
the
fix-non-deterministic
branch
from
782d5cd to
3d6419b
Compare
yihuang
requested review from
austinchandra and
adisaran64
and removed request for
a team
yihuang
commented
Nov 9, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
=======================================
Coverage 59.93% 59.93%
=======================================
Files 109 109
Lines 10259 10259
=======================================
Hits 6149 6149
Misses 3839 3839
Partials 271 271
|
adisaran64
reviewed
Nov 9, 2022
There was a problem hiding this comment.
@yihuang looks like integration tests are failing. could you take a look?
fedekunze
reviewed
Nov 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there's extra-eips, concurrent query could cause non-deterministic evm execution result.
It could affect even if extra-eips only exists in historical states.
Ref: ethereum/go-ethereum#26137
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)