fix(rpc): wrong block number in debug trace related api

[mmsqe]

Closes: #XXX

Description

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #1591 (e67f579) into main (47fdfd3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e67f579 differs from pull request most recent head 36bb123. Consider uploading reports for the commit 36bb123 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1591   +/-   ##
=======================================
  Coverage   68.33%   68.33%           
=======================================
  Files         110      110           
  Lines       10184    10184           
=======================================
  Hits         6959     6959           
  Misses       2821     2821           
  Partials      404      404           

Impacted Files	Coverage Δ
x/evm/keeper/grpc_query.go	85.90% <100.00%> (ø)

[VictorTrustyDev]

block height already minus by one in rpc

ethermint/rpc/backend/tracing.go

Lines 110 to 114 in 57ed355

	contextHeight := transaction.Height - 1
	if contextHeight < 1 {
	// 0 is a special value in `ContextWithHeight`
	contextHeight = 1
	}

Oh no, so currently it keep minus by one in grpc so actually minus by 2? If calling via API debug_traceTransaction?

[mmsqe]

block height already minus by one in rpc

ethermint/rpc/backend/tracing.go

Lines 110 to 114 in 57ed355

	contextHeight := transaction.Height - 1
	if contextHeight < 1 {
	// 0 is a special value in `ContextWithHeight`
	contextHeight = 1
	}

Oh no, so currently it keep minus by one in grpc so actually minus by 2? If calling via API debug_traceTransaction?

Fixing BlockNumber from request, no need minus 1

[yihuang]

The contextHeight is minus one to get to the state of block beginning, but the block number pass to evm context should not minus one.

[4rgon4ut]

LGTM! Good job @mmsqe

[facs95]

Hey @yihuang have you ever seen the fixed-output derivation.. nix issues that are making the integration tests fail?