This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
perf: make use of sender cache to reduce hotspot #1705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
=======================================
Coverage 68.20% 68.20%
=======================================
Files 112 112
Lines 10167 10168 +1
=======================================
+ Hits 6934 6935 +1
Misses 2827 2827
Partials 406 406
|
yihuang
reviewed
Mar 9, 2023
| @@ -331,7 +331,8 @@ func (msg MsgEthereumTx) AsMessage(signer ethtypes.Signer, baseFee *big.Int) (co | |||
| // GetSender extracts the sender address from the signature values using the latest signer for the given chainID. | |||
| func (msg *MsgEthereumTx) GetSender(chainID *big.Int) (common.Address, error) { | |||
| signer := ethtypes.LatestSignerForChainID(chainID) | |||
| from, err := signer.Sender(msg.AsTransaction()) | |||
| tx := msg.AsTransaction() | |||
There was a problem hiding this comment.
we better to fill the tx.from field using msg.From here.
There was a problem hiding this comment.
yes? ethtyes.Sender set in tx.from.Store
There was a problem hiding this comment.
but the tx is a temporary object, cache sender inside is not useful, we might need to find a way to cache the eth tx itself.
There was a problem hiding this comment.
crypto-org-chain#227
I did a simple fix here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1703
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)