Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: nil pointer panic in ApplyNativeMessage #660

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Oct 12, 2021

Solution:

  • pass NoOpTracer

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #660 (af54837) into main (89e2b29) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   57.04%   57.03%   -0.02%     
==========================================
  Files          63       63              
  Lines        5534     5535       +1     
==========================================
  Hits         3157     3157              
- Misses       2214     2215       +1     
  Partials      163      163              
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 66.97% <0.00%> (-0.21%) ⬇️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending Changelog bug fix

@yihuang
Copy link
Contributor Author

yihuang commented Oct 13, 2021

ACK, pending Changelog bug fix

thanks, changelog added.

@fedekunze fedekunze merged commit 2e06759 into evmos:main Oct 13, 2021
@yihuang yihuang deleted the nil-tracer branch October 13, 2021 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants