This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
store base fee in event #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
thomas-nguy
force-pushed
the
thomas/base-fee-event
branch
from
7cb4774 to
a5d8ea5
Compare
Codecov Report
@@ Coverage Diff @@
## main #673 +/- ##
==========================================
- Coverage 57.02% 56.89% -0.13%
==========================================
Files 63 63
Lines 5547 5559 +12
==========================================
Hits 3163 3163
- Misses 2221 2233 +12
Partials 163 163
|
thomas-nguy
commented
Oct 14, 2021
rpc/ethereum/backend/backend.go
Outdated
| resParams, err := e.queryClient.FeeMarket.Params(types.ContextWithHeight(height), &feemarkettypes.QueryParamsRequest{}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| baseFee := big.NewInt(resParams.Params.InitialBaseFee) | ||
| baseFee = big.NewInt(resParams.Params.InitialBaseFee) |
There was a problem hiding this comment.
It should be Genesis baseFee, not InitialBaseFee there, but logic is not completely clear
thomas-nguy
force-pushed
the
thomas/base-fee-event
branch
7 times, most recently
from
b108175 to
a8ab919
Compare
thomas-nguy
commented
Oct 14, 2021
thomas-nguy
force-pushed
the
thomas/base-fee-event
branch
from
a8ab919 to
1fdb0b0
Compare
fedekunze
approved these changes
Oct 14, 2021
x/feemarket/types/params.go
Outdated
| @@ -80,6 +80,10 @@ func (p Params) Validate() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *Params) IsBaseFeeEnable(height int64) bool { | |||
There was a problem hiding this comment.
Suggested change
| func (p *Params) IsBaseFeeEnable(height int64) bool { | |
| func (p *Params) IsBaseFeeEnabled(height int64) bool { |
thomas-nguy
force-pushed
the
thomas/base-fee-event
branch
from
e70e305 to
a793e61
Compare
thomas-nguy
force-pushed
the
thomas/base-fee-event
branch
from
b29fca7 to
0331319
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)