This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
ENG 256 fix gosec issues #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-256 Fix gosec issues on Ethermint and Evmos
Follow up from ENG-255
cc: @prajjwol |
fedekunze
reviewed
Nov 24, 2021
fedekunze
reviewed
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
==========================================
- Coverage 57.45% 57.42% -0.04%
==========================================
Files 71 71
Lines 6107 6111 +4
==========================================
Hits 3509 3509
- Misses 2396 2400 +4
Partials 202 202
|
fedekunze
reviewed
Nov 25, 2021
…attribute for chain id
fedekunze
added
backport/0.16.x
leejw51crypto
pushed a commit
to leejw51crypto/ethermint
that referenced
this pull request
Nov 30, 2021
* remove gosec warnigs with medium severity * Improvement(Ethermint): Fix gosec vulnerabilities * Improvement(Evmos): address pr comments * Improvement(Ethermint): Fix flags test by using PersistentFlags() instead of Flags() * Improvement(Ethermint): Fix return of defer function * Improvement(Ethermint): Replace PersistentFlags with Flags * Apply suggestions from code review * Improvement(Ethermint): Use persisentFlags again and remove required attribute for chain id Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/tharsis/issue/ENG-256/fix-gosec-issues-on-ethermint-and-evmos
Description
This PR fixes the last vulerabilities pointed out by
gosecin order to makegosecrequired for github workflows.Note
On merge, an admin of this repo needs to set the gosec github action to required