Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

improve error message in SendTransaction json-rpc api (backport #786) #788

Closed
wants to merge 3 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 26, 2021

This is an automatic backport of pull request #786 done by Mergify.
Cherry-pick of c8d4d3f has failed:

On branch mergify/bp/release/v0.8.x/pr-786
Your branch is up to date with 'origin/release/v0.8.x'.

You are currently cherry-picking commit c8d4d3f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   app/ante/ante.go
	modified:   app/ante/eth.go
	modified:   go.mod
	modified:   go.sum
	modified:   rpc/ethereum/backend/backend.go
	modified:   rpc/ethereum/namespaces/eth/api.go
	modified:   rpc/ethereum/namespaces/miner/api.go
	modified:   x/evm/keeper/grpc_query.go
	modified:   x/evm/keeper/keeper.go
	modified:   x/evm/keeper/msg_server.go
	modified:   x/evm/keeper/state_transition.go
	modified:   x/evm/keeper/utils.go
	modified:   x/evm/types/chain_config.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix error message in `SendTransaction` json-rpc api

Closes: #785

Solution:
- Remove `stacktrace.Propagate`s, and recover error message in jsonrpc server

changelog

fix error messages

* Update x/evm/keeper/msg_server.go

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit c8d4d3f)

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #788 (0842eb9) into release/v0.8.x (70480d2) will decrease coverage by 0.11%.
The diff coverage is 56.38%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v0.8.x     #788      +/-   ##
==================================================
- Coverage           57.45%   57.34%   -0.12%     
==================================================
  Files                  71       71              
  Lines                6107     6037      -70     
==================================================
- Hits                 3509     3462      -47     
+ Misses               2396     2373      -23     
  Partials              202      202              
Impacted Files Coverage Δ
app/ante/ante.go 49.38% <0.00%> (+1.18%) ⬆️
x/evm/keeper/grpc_query.go 66.09% <0.00%> (ø)
x/evm/keeper/keeper.go 75.86% <0.00%> (ø)
x/evm/keeper/msg_server.go 73.58% <0.00%> (ø)
x/evm/keeper/state_transition.go 76.97% <23.52%> (+0.07%) ⬆️
app/ante/eth.go 85.10% <72.72%> (+2.81%) ⬆️
x/evm/keeper/utils.go 72.85% <72.72%> (-2.15%) ⬇️
x/evm/types/chain_config.go 100.00% <100.00%> (ø)

@fedekunze fedekunze enabled auto-merge (squash) November 26, 2021 14:30
@fedekunze fedekunze closed this Dec 7, 2021
auto-merge was automatically disabled December 7, 2021 16:45

Pull request was closed

@mergify mergify bot deleted the mergify/bp/release/v0.8.x/pr-786 branch December 7, 2021 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants