Hbs strategy #186
Merged
Hbs strategy #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherdman
reviewed
Mar 16, 2021
jherdman
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
LGTM, though one last request: can you rebase away all of the merge commits? In fact, just squashing this down to a single commit would be ideal.
Lastly, I'd love to hear from @ivanvotti re dropping a bunch of the old Ember's from the build pipeline.
betocantu93
force-pushed
the
hbs-strategy
branch
from
0463b33 to
a1e79c8
Compare
|
@jherdman nooot sure if I did it correctly lol, never done these kind of git operations manually! it looks fine I think I did: $git reset --soft hbs-deps What do you think? maybe I can learn a new thing :) |
|
OK! We're down to the final steps! One last rebase and we're good to go! |
betocantu93
force-pushed
the
hbs-strategy
branch
from
a1e79c8 to
19b0603
Compare
|
@jherdman ready ! 👍🏼 👍🏼 |
jherdman
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #185, its the actual hbs strategy implementation from #166