Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaladoc for KafkaJournal and related classes #478

Merged
merged 8 commits into from
Jul 3, 2023
Merged

Conversation

rtar
Copy link
Contributor

@rtar rtar commented Jun 20, 2023

No description provided.

@coveralls
Copy link

coveralls commented Jun 20, 2023

Pull Request Test Coverage Report for Build 5443845645

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 82.488%

Totals Coverage Status
Change from base Build 5345487092: 1.1%
Covered Lines: 3189
Relevant Lines: 3866

💛 - Coveralls

@rtar rtar changed the title Work in progress on adding more scaladocs. Add scaladoc for KafkaJournal and related classes Jun 22, 2023
@rtar rtar force-pushed the more-scaladocs branch from 8bdd34e to 07d18c9 Compare July 3, 2023 11:17
*
* 1. Take over the ownership of the journal, meaning nobody write to it
* except us.
* 1. Write a special marker to Kafka, encountring which, while reading, will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to increment numbers

def apply[F[_] : BracketThrowable](
// TODO add range argument
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's drop this TODO

@rtar rtar merged commit 81bbeca into master Jul 3, 2023
@rtar rtar mentioned this pull request Jul 4, 2023
@rtar rtar deleted the more-scaladocs branch July 17, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants