Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci build test #175

Merged
merged 8 commits into from
Jul 21, 2020
Merged

Ci build test #175

merged 8 commits into from
Jul 21, 2020

Conversation

duncdrum
Copy link
Contributor

@duncdrum duncdrum commented Jul 20, 2020

this makes the errors i see when trying to build, visible on travis.
Basically if this passes without a glitch ppl should be able to build

node12 is actively tested on Ubuntu with python2 and python3, these tests are allowed to fail on macOS
see #176

build errors are gone, readme updated, and we are now testing in clean contemporary environments as well as historic environments. We are also testing against node14 on linux, and node12 on macOS catalina to see if upstream changes are creating new build possibilities.

close #174

@cla-bot cla-bot bot added the cla-signed label Jul 20, 2020
@duncdrum duncdrum force-pushed the CI-build-test branch 2 times, most recently from 84bde4b to 2248e5a Compare July 20, 2020 16:12
@duncdrum duncdrum force-pushed the CI-build-test branch 5 times, most recently from bd0baa9 to cdaf800 Compare July 21, 2020 12:24
* fix(ci): use exclude and allow_failure

requires top level matrix expansion

* (ci): refactor to remove duplicate matrix expansions

* ci(travis): test global install

* ci(travis): global python3

* fixup(ci): final cleanup
@duncdrum duncdrum marked this pull request as ready for review July 21, 2020 17:05
@duncdrum duncdrum changed the title [WIP} Ci build test [WIP] Ci build test Jul 21, 2020
@duncdrum duncdrum changed the title [WIP] Ci build test Ci build test Jul 21, 2020
@adamretter adamretter merged commit ce2bd83 into evolvedbinary:master Jul 21, 2020
@adamretter
Copy link
Member

Thanks @duncdrum there is some great stuff in here. I merged it. The only bit I excluded was about installing a global node-gyp, as my experience is that we don't have to do that on Travis for any of the builds.

It might be worth adding back into the README.md as a troubleshooting bit... what do you think?

@duncdrum
Copy link
Contributor Author

the links on the readme will contain that info, was more intended to test node-gyp in the environment before the actual build, to catch errors early on.

By removing the global python ENV you are now building on EOL python2 by default, although all these VMs come with a python3 install as well. Minor gripe, but to get more accurate testing I would prefer keeping python3 as the default, since i assume most users use that, instead of the EOL version.

@duncdrum duncdrum deleted the CI-build-test branch July 22, 2020 08:13
@adamretter
Copy link
Member

@duncdrum I figured that as the system default is Python2 and Theia expects Python2 (at the moment), then we would stick with that until Theia decide what to do about eclipse-theia/theia#8216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build errors
2 participants