-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci build test #175
Ci build test #175
Conversation
84bde4b
to
2248e5a
Compare
some changes to gitignore documenting the saga
bd0baa9
to
cdaf800
Compare
* fix(ci): use exclude and allow_failure requires top level matrix expansion * (ci): refactor to remove duplicate matrix expansions * ci(travis): test global install * ci(travis): global python3 * fixup(ci): final cleanup
Thanks @duncdrum there is some great stuff in here. I merged it. The only bit I excluded was about installing a global node-gyp, as my experience is that we don't have to do that on Travis for any of the builds. It might be worth adding back into the README.md as a troubleshooting bit... what do you think? |
the links on the readme will contain that info, was more intended to test node-gyp in the environment before the actual build, to catch errors early on. By removing the global python |
@duncdrum I figured that as the system default is Python2 and Theia expects Python2 (at the moment), then we would stick with that until Theia decide what to do about eclipse-theia/theia#8216 |
this makes the errors i see when trying to build, visible on travis.
Basically if this passes without a glitch ppl should be able to build
node12
is actively tested on Ubuntu withpython2
andpython3
, these tests are allowed to fail on macOSsee #176
build errors are gone, readme updated, and we are now testing in clean contemporary environments as well as historic environments. We are also testing against
node14
on linux, andnode12
on macOS catalina to see if upstream changes are creating new build possibilities.close #174