Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(initContainers): introduce init containers to pods #149

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat(initContainers): introduce init containers to pods #149

merged 1 commit into from
Aug 19, 2024

Conversation

mipieta
Copy link
Contributor

@mipieta mipieta commented Aug 1, 2024

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have made design choices.
  • My design choices are documented in an Architecture Decision Record in the designated ARD folder of this repo.

Issues this PR fixes

Fixes #

bjorges
bjorges approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@bjorges bjorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mipieta mipieta merged commit 80ba74e into evry-ace:master Aug 19, 2024
1 check passed
@mipieta mipieta deleted the init_containers branch August 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasz-wojcik-14 lukasz-wojcik-14 lukasz-wojcik-14 approved these changes

@arham-nadeem-butt arham-nadeem-butt arham-nadeem-butt approved these changes

@alexander-melsom alexander-melsom alexander-melsom approved these changes

@marcelgrygar marcelgrygar marcelgrygar approved these changes

@MGr-Sektetor MGr-Sektetor MGr-Sektetor approved these changes

@bjorges bjorges bjorges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mipieta @bjorges @MGr-Sektetor @marcelgrygar @alexander-melsom @arham-nadeem-butt @lukasz-wojcik-14