New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove peer deps, allow use of 'import' #24

Open

C-D-Lewis wants to merge 5 commits into master from node-build

Contributor

C-D-Lewis commented Jun 1, 2021 •

edited

Loading

Same pattern as for evrythng.js, as opposed to current way that creates a global value.

Changes:

Add separate 'node-style' build output, allowing import ScanThng from 'scanthng'; instead of <script>
Existing use of <script> should still work. (TODO: test this)
Don't use window to access evrythng and jsQR
Require evrythng and jqQR explicitly, allowing use of User scope.

Problems:

Bundle size increases from 13K to 183K-333K depending on import method due to including evrythng and jsQR directly.
evrythng.settings inside scanthng.js is not affected by evrythng.setup() called in the implementing app...

C-D-Lewis added 5 commits

June 1, 2021 16:13


          Begin requirable version

df4aa83


          Require evrythng and jqQR directly

859f17e


          Rename browser bundle name

315f870


          Add test/react-app to test import

6c6e6b0


          Merge branch 'master' into node-build

1a53879

C-D-Lewis changed the title ~~Begin requirable version~~ Remove peer deps, allow use of 'import'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet