bytecode: Implement string literals and operations #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for 0d95949 |
juliaogris
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
aah, so now the OpStringLessThan etc come together, yes makes sense to me to have them is seprate operators and not do the typecheck during runtime.
Again, lgtm, curious to see what @camh- will find.
Add an internal representation for strings to the package and support assigning strings. Add opcodes for concatenating and comparing strings. The compiler takes the burden of type checking the arguments so that the vm can run an optimised hot path.
juliaogris
force-pushed
the
compiler-strings
branch
from
4f9a2b5
to
0d95949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an internal representation for strings to the package and support
assigning strings. Add opcodes for concatenating and comparing strings.
The compiler takes the burden of type checking the arguments so that
the vm can run an optimised hot path.