lazy load Rich #154
Merged
lazy load Rich #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwreeves
force-pushed
the
lazy-load-rich-dependencies
branch
from
837c66f
to
76a50c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Rich is only used to render help text; it's entirely unnecessary during normal code execution unless the user is explicitly using it in their code.
Start-up speed is a nonzero factor in adoption of Click and, by extension, Rich-Click. See for example this discussion in the Airflow repo where Click (and Rich-Click!!!) was considered, and then ultimately dropped in part for performance reasons. apache/airflow#22613 (comment)
It's very low cost to use
typing.TYPE_CHECKINGto defer loading anything related to Rich (except for type checking), and lazy then load therich_help_rendering.pymodule. These are not major performance gains, but they're not nothing either.